Minor improvements in GPT2 tokenizer#3567
Merged
goerch merged 2 commits intoggml-org:masterfrom Oct 10, 2023
Merged
Conversation
goerch
changed the title
ggerganov
approved these changes
Oct 10, 2023
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Does this make the tokenization of wikitext match with the Python, or is there still the 4-digit tokenization discrepancy?
Contributor
Author
The 4-digit tokenization discrepancy could be a bug in HF fast tokenizers. |
Member
|
Thank you for the thorough investigation. After @cebtenzzre's review we can merge this |
Contributor
|
remaining discrepancy from HF is caused by different pretokenzation: #3502 (comment) |
joelkuiper
added a commit
to vortext/llama.cpp
that referenced
this pull request
Oct 12, 2023
…example * 'master' of github.com:ggerganov/llama.cpp: (34 commits) examples: support LLaVA v1.5 (multimodal model) (ggml-org#3436) docs : fix typo GOMP_CPU_AFFINITY (ggml-org#3597) cmake : fix add_compile_options on macOS typo : it is `--n-gpu-layers` not `--gpu-layers` (ggml-org#3592) ci : check if there is enough VRAM (ggml-org#3596) server : add completion mode (no chat) (ggml-org#3582) prompts : add mnemonics.txt server : fix kv cache management (ggml-org#3588) main : fix session loading bug (ggml-org#3400) server : add parameter -tb N, --threads-batch N (ggml-org#3584) common : fix mirostat state when using multiple sequences (ggml-org#3543) batched : add bench tool (ggml-org#3545) examples : add batched.swift + improve CI for swift (ggml-org#3562) Add MPT model to supported models in README.md (ggml-org#3574) Minor improvements in GPT2 tokenizer (ggml-org#3567) readme : add bloom (ggml-org#3570) llm : add bloom models (ggml-org#3553) swift : improvements and fixes (ggml-org#3564) llm : add MPT support (ggml-org#3417) infill. : fix tokenization (ggml-org#3508) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes our bugs in #3502.
@cmp-nct : the small fixes in
bpe_gpt2_preprocesscould be relevant for you?